Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broken notebook cta_sensitivity.ipynb #1943

Closed
Bultako opened this issue Nov 23, 2018 · 2 comments
Closed

Broken notebook cta_sensitivity.ipynb #1943

Bultako opened this issue Nov 23, 2018 · 2 comments
Assignees
Labels
Projects
Milestone

Comments

@Bultako
Copy link
Member

Bultako commented Nov 23, 2018

This noteboook is not delivered by gammapy download tutorials but we keep in this repo because it is referenced from other pages in the documentation.

$ gammapy jupyter --src=./tutorials/cta_sensitivity.ipynb test
INFO:gammapy.scripts.jupyter:   ... EXECUTING tutorials/cta_sensitivity.ipynb
INFO:gammapy.scripts.jupyter:   ... Executing duration: 0.07 mn
INFO:gammapy.scripts.jupyter:   ... FAILED
INFO:gammapy.scripts.jupyter:

ImportError in cell [2]

--SOURCE CODE: 
from gammapy.irf import CTAPerf
from gammapy.spectrum import SensitivityEstimator

--TRACEBACK: 
---------------------------------------------------------------------------
ImportError                               Traceback (most recent call last)
<ipython-input-2-b9f53885d5c3> in <module>
----> 1 from gammapy.irf import CTAPerf
      2 from gammapy.spectrum import SensitivityEstimator

ImportError: cannot import name 'CTAPerf' from 'gammapy.irf' (/Users/jer/git/gammapy/gammapy/gammapy/irf/__init__.py)

As an add-on to this issue, when I tried to fix the notebook, I found that spectrum.SensitivityEstimator breaks with the DC1 IRFs. It works fine with those in https://github.com/gammapy/gammapy-extra/tree/master/datasets/cta/perf_prod2/point_like_non_smoothed

@cdeil cdeil added the bug label Nov 23, 2018
@cdeil cdeil added this to the 0.10 milestone Nov 23, 2018
@cdeil cdeil added this to To do in gammapy.irf via automation Nov 23, 2018
@cdeil
Copy link
Contributor

cdeil commented Nov 23, 2018

@Bultako - Please mark the notebook as broken for now.

This is known, @registerrier said he would fix this.
Related issues (mostly all about the same task): #1824, #1551, #876, #809

@registerrier - Please make this your priority in Gammapy, and please do it in steps to keep the basic functionality of SpectrumSimulation and SensitivityEstimator working, so that it's fixed for v0.10, even if developing complete and good new background model and dataset classes will take many months.

@registerrier
Copy link
Contributor

This issue should be solved after PR #2000.

@adonath adonath closed this as completed Jan 25, 2019
gammapy.irf automation moved this from To do to Done Jan 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
gammapy.irf
  
Done
Development

No branches or pull requests

4 participants