Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unify Fermi-LAT datasets used in Gammapy #1994

Merged
merged 18 commits into from Jan 23, 2019

Conversation

adonath
Copy link
Member

@adonath adonath commented Jan 21, 2019

This PR addresses #1827. It replaces all the fermi datasets currently used in the Gammapy tests, docs and tutorials with a single 3FHL example of the Galactic center.

There is one exception: the fermi_lat.ipynb tutorial, which shows how to prepare a dataset from Fermi-LAT allsky data. Replacing the data there with the prepared dataset does not make sense, as the tutorial would only show loading and fitting the data.

@adonath adonath added this to the 0.10 milestone Jan 21, 2019
@adonath adonath self-assigned this Jan 21, 2019
@Bultako
Copy link
Member

Bultako commented Jan 21, 2019

@adonath
If I understand correctly, once this PR merged the only fermi-lat datasets needed in Gammapy would be the new ones that are added here plus those present in https://github.com/gammapy/gammapy/blob/master/tutorials/fermi_lat.ipynb?

We talked recently about downloading versioned datasets with gammapy download. I have added this functionality in PR #1988 commit c4a3456

@Bultako
Copy link
Member

Bultako commented Jan 22, 2019

@adonath
In the file https://github.com/gammapy/gammapy/blob/master/tutorials/notebooks.yaml we can declare the datasets needed for each notebook, so gammapy download can fetch the needed datasets to reproduce all the notebooks or a specific single one.

I think this file needs to be modified to incorporate the changes made in this PR.

@adonath
Copy link
Member Author

adonath commented Jan 22, 2019

@Bultako Thanks, you're right! I'll add the change now...

@Bultako
Copy link
Member

Bultako commented Jan 22, 2019

@adonath
So, are you ok to remove DatasetFermi2FHL, DatasetFermiSurvey and DatasetFermiLat from https://github.com/gammapy/gammapy-webpage/blob/gh-pages/make.py#L194-L206? Then we could generate a smaller JSON for the datasets https://github.com/gammapy/gammapy-webpage/blob/gh-pages/download/data/gammapy-data-index.json that will eventually become a gammapy-0.10-data-index.json when releasing.

@adonath
Copy link
Member Author

adonath commented Jan 22, 2019

@Bultako Yes, I'm fine with removing those. I can prepare a PR for this later...

@adonath
Copy link
Member Author

adonath commented Jan 23, 2019

The remaining Travis fail is unrelated. I"ll merge this PR now.

@adonath adonath merged commit fa93796 into gammapy:master Jan 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants