New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add FoVBackgroundMaker class #2697
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2697 +/- ##
=========================================
+ Coverage 91.66% 91.7% +0.04%
=========================================
Files 142 143 +1
Lines 15988 16040 +52
=========================================
+ Hits 14655 14710 +55
+ Misses 1333 1330 -3
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot @registerrier, I've left one minor inline comment concerning the fit
method.
I think we should also add an example somewhere how to use this class, either in docs/cube/index.rst
or maybe analysis_2.ipynb
.
Otherwise looks good to me. Please merge whenever you think its ready.
Modifications to the tutorials will be made in a further pull request. |
Description
This pull request introduces a
FoVBackgroundMaker
class. It is very simple. It takes an exclusion mask on__init__
.FoVBackgroundMaker.run(dataset)
simply performs a fit of the model. The assumption here is that it only consists of thebackground_model
.Tests have been included, in particular one checking that in case of non-convergence the parameters are the initial ones. In this case a simple
log.warning
is raised. (this should be tested properly). It is not clear that this is the best behavior. Because ideally the dataset should be excluded.Dear reviewer
please comment on the choice of for non-convergence.