Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce gammapy.datasets submodule #2788

Merged
merged 11 commits into from Feb 24, 2020
Merged

Conversation

adonath
Copy link
Member

@adonath adonath commented Feb 24, 2020

Description

This pull request introduce a new gammapy.datasets sub-module. The motivation for this is outlined in PIG-19 (see #2720). It includes the following changes:

  • Move cube/fit.py to datasets/map.py
  • Move spectrum/dataset.py to datasets/spectrum.py
  • Move spectrum/flux_points.py to datasets/flux_points.py
  • Move the dataset part of modelling/serialize.py to datasets/io.py
  • Move DATASETS registry to gammapy/datasets
  • Introduce gammapy/utils/registry.py
  • Preliminarily Move CountsSpectrum to gammapy.maps
  • Remove unused simulate_dataset function

Dear reviewer
No need for a real review. I'll wait for Travis to be green and then merge.

@adonath adonath self-assigned this Feb 24, 2020
@adonath adonath added this to the 0.17 milestone Feb 24, 2020
@codecov
Copy link

codecov bot commented Feb 24, 2020

Codecov Report

Merging #2788 into master will increase coverage by 0.06%.
The diff coverage is 92.92%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2788      +/-   ##
==========================================
+ Coverage   92.21%   92.27%   +0.06%     
==========================================
  Files         144      148       +4     
  Lines       16576    16576              
==========================================
+ Hits        15286    15296      +10     
+ Misses       1290     1280      -10
Impacted Files Coverage Δ
gammapy/cube/__init__.py 100% <ø> (ø) ⬆️
gammapy/modeling/__init__.py 100% <ø> (ø) ⬆️
gammapy/maps/counts_spectrum.py 93.18% <ø> (ø)
gammapy/spectrum/__init__.py 100% <ø> (ø) ⬆️
gammapy/datasets/map.py 91.02% <100%> (ø)
gammapy/modeling/fit.py 93.52% <100%> (ø) ⬆️
gammapy/time/lightcurve_estimator.py 96.12% <100%> (+0.02%) ⬆️
gammapy/modeling/models/__init__.py 100% <100%> (+21.42%) ⬆️
gammapy/maps/wcsnd.py 96.36% <100%> (ø) ⬆️
gammapy/data/event_list.py 90.11% <100%> (ø) ⬆️
... and 26 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4d66bec...8ac7de2. Read the comment docs.

@adonath adonath merged commit 7bccc42 into gammapy:master Feb 24, 2020
@adonath adonath mentioned this pull request Feb 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant