-
Notifications
You must be signed in to change notification settings - Fork 188
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement FluxEstimator #2810
Implement FluxEstimator #2810
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2810 +/- ##
==========================================
+ Coverage 92.17% 92.21% +0.03%
==========================================
Files 147 148 +1
Lines 16636 16678 +42
==========================================
+ Hits 15334 15379 +45
+ Misses 1302 1299 -3
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @registerrier, I've left a few inline comments.
Minor: I think the _estimator
suffix in the file name is not needed, as the file is already in the gammapy.estimators
sub-package. Maybe introduce core.py
and move the ParameterEstimator
and FluxEstimator
there?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @registerrier, so far I have no further comments.
Description
This pull request introduces the
FluxEstimator
.So far result return is in the form of a
dict
. Do we prefer to have aTable
row instead?Dear reviewer
Some work still needed.
The early PR should help test with the new scipy 1.4.1.