Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add temporal evaluation for spectral datasets #2823

Merged
merged 1 commit into from Mar 12, 2020
Merged

Add temporal evaluation for spectral datasets #2823

merged 1 commit into from Mar 12, 2020

Conversation

AtreyeeS
Copy link
Member

@AtreyeeS AtreyeeS commented Mar 11, 2020 •
edited

This pull request passes GTIs to MapEvaluator from SpectrumDataset to enable computation of temporal models

@AtreyeeS AtreyeeS requested a review from adonath March 11, 2020 23:57
@AtreyeeS AtreyeeS self-assigned this Mar 11, 2020
@AtreyeeS AtreyeeS added this to In progress in gammapy.modeling via automation Mar 11, 2020
@AtreyeeS AtreyeeS added this to the 0.17 milestone Mar 11, 2020
@codecov
Copy link

codecov bot commented Mar 12, 2020 •
edited

Codecov Report

Merging #2823 into master will not change coverage by %.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2823   +/-   ##
=======================================
  Coverage   91.98%   91.98%           
=======================================
  Files         147      147           
  Lines       16559    16559           
=======================================
  Hits        15232    15232           
  Misses       1327     1327
Impacted Files Coverage Δ
gammapy/datasets/spectrum.py 95.39% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b4b548c...32b0975. Read the comment docs.

adonath
adonath approved these changes Mar 12, 2020
View reviewed changes
Copy link
Member

@adonath adonath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @AtreyeeS, I have no further comments...

@adonath adonath merged commit 5e5bcbc into gammapy:master Mar 12, 2020
gammapy.modeling automation moved this from In progress to Done Mar 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adonath adonath adonath approved these changes

Assignees

@AtreyeeS AtreyeeS

Labels
feature
Projects
gammapy.modeling
  
Done
Milestone
0.17
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@AtreyeeS @adonath