Reuse FluxPointsEstimator in LightCurveEstimator #2993
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adonath
force-pushed
the
reuse_flux_points_estimator
branch
from
298a14a
to
ae448e4
Compare
registerrier
approved these changes
Aug 31, 2020
|
Thanks @registerrier! I'll go ahead and merge now... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request is a proof of concept to re-use the
FluxPointsEstimatorin theLightCurveEstimator. Therein arguments for this are the following:However this change modifies the current method, because by introducing the
FluxPointsEstimatorthe fit range is limited to the specified energy range. Previously the fit was always done on the full energy range and then flux was derived from the best fit model in the specified energy range.