Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement HpxNDMap.to_region_nd_map #3308

Merged
merged 5 commits into from Apr 13, 2021

Conversation

adonath
Copy link
Member

@adonath adonath commented Apr 13, 2021

Description

This pull request implements HpxNDMap.to_region_nd_map and HpxGeom.region_mask. This allow to extract a RegionNDMap from a HpxNDMap using various methods.

@adonath adonath self-assigned this Apr 13, 2021
@adonath adonath added this to To do in gammapy.maps via automation Apr 13, 2021
@adonath adonath added this to the v0.19 milestone Apr 13, 2021
@codecov
Copy link

codecov bot commented Apr 13, 2021

Codecov Report

Merging #3308 (fb15722) into master (75398b6) will decrease coverage by 0.03%.
The diff coverage is 80.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3308      +/-   ##
==========================================
- Coverage   93.85%   93.81%   -0.04%     
==========================================
  Files         144      144              
  Lines       17968    17998      +30     
==========================================
+ Hits        16864    16885      +21     
- Misses       1104     1113       +9     
Impacted Files Coverage Δ
gammapy/maps/hpxnd.py 94.38% <77.27%> (-1.07%) ⬇️
gammapy/maps/hpx.py 88.32% <87.50%> (-0.01%) ⬇️
gammapy/modeling/iminuit.py 92.39% <0.00%> (-3.27%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 75398b6...fb15722. Read the comment docs.

@adonath adonath merged commit b36cb89 into gammapy:master Apr 13, 2021
gammapy.maps automation moved this from To do to Done Apr 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
gammapy.maps
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

1 participant