Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Safe mask functions should not rely on the projected IRFs #3878

Closed
AtreyeeS opened this issue Apr 8, 2022 · 1 comment · Fixed by #4599
Closed

Safe mask functions should not rely on the projected IRFs #3878

AtreyeeS opened this issue Apr 8, 2022 · 1 comment · Fixed by #4599
Assignees
@AtreyeeS
Labels
feature-request
Milestone
1.2

Comments

@AtreyeeS
Copy link
Member

AtreyeeS commented Apr 8, 2022

Continuing from the discussions in #3873, maybe safe mask functions should not use the binned IRFs, but rather the DL3 irfs directly when possible. This is a reminder issue for v1.0
@adonath
Copy link
Member

adonath commented May 3, 2022

@AtreyeeS This is a backwards incompatible change and it would be bad to introduce it between v1.0rc and v1.0, because it might change analysis results. I'll label the issue after v1.0.

@adonath adonath added this to the 1.1 milestone May 3, 2022
@registerrier registerrier modified the milestones: 1.1, 1.2 Mar 24, 2023
@AtreyeeS AtreyeeS self-assigned this Jun 19, 2023
@AtreyeeS AtreyeeS mentioned this issue Jun 20, 2023
Merged
@AtreyeeS AtreyeeS linked a pull request Jun 20, 2023 that will close this issue
Add a SafeMaskMaker at DL3 level #4599
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AtreyeeS AtreyeeS

Labels
feature-request
Projects
None yet
Milestone
1.2
Development

Successfully merging a pull request may close this issue.

Add a SafeMaskMaker at DL3 level AtreyeeS/gammapy
3 participants
@adonath @registerrier @AtreyeeS