Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the SafeMaskMaker #3987

Merged
merged 9 commits into from Jun 15, 2022
Merged

Fix the SafeMaskMaker #3987

merged 9 commits into from Jun 15, 2022

Conversation

bkhelifi
Copy link
Member

@bkhelifi bkhelifi commented Jun 11, 2022

Description
This pull request is associated to the issue #3984. It fixes 2 things as discussed during the last dev call

Dear reviewer
This PR is aimed for the bug release V0.20.2

@bkhelifi bkhelifi added the bug label Jun 11, 2022
@bkhelifi bkhelifi added this to the 0.20.1 milestone Jun 11, 2022
@bkhelifi bkhelifi added this to To do in gammapy.makers via automation Jun 11, 2022
@codecov
Copy link

codecov bot commented Jun 11, 2022

Codecov Report

Merging #3987 (af5f86b) into master (7b4dab6) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #3987      +/-   ##
==========================================
- Coverage   94.04%   94.04%   -0.01%     
==========================================
  Files         162      162              
  Lines       21391    21401      +10     
==========================================
+ Hits        20118    20127       +9     
- Misses       1273     1274       +1     
Impacted Files Coverage Δ
gammapy/makers/safe.py 88.88% <100.00%> (+1.16%) ⬆️
gammapy/modeling/iminuit.py 92.52% <0.00%> (-1.87%) ⬇️
gammapy/astro/darkmatter/spectra.py 98.36% <0.00%> (ø)
gammapy/modeling/fit.py 95.56% <0.00%> (+0.03%) ⬆️
gammapy/maps/region/geom.py 93.21% <0.00%> (+0.10%) ⬆️

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

Copy link
Contributor

@registerrier registerrier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @bkhelifi!

Main comment here is that tests should be added to ensure the issues are properly corrected and that future changes do not break this.

gammapy/makers/safe.py Show resolved Hide resolved
gammapy/makers/safe.py Show resolved Hide resolved
gammapy/makers/safe.py Outdated Show resolved Hide resolved
gammapy/makers/safe.py Outdated Show resolved Hide resolved
gammapy/makers/safe.py Outdated Show resolved Hide resolved
gammapy.makers automation moved this from To do to In progress Jun 13, 2022
@registerrier registerrier linked an issue Jun 13, 2022 that may be closed by this pull request
gammapy/makers/safe.py Outdated Show resolved Hide resolved
gammapy/makers/safe.py Outdated Show resolved Hide resolved
Copy link
Contributor

@registerrier registerrier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @bkhelifi

@registerrier registerrier merged commit 7d03123 into gammapy:master Jun 15, 2022
gammapy.makers automation moved this from In progress to Done Jun 15, 2022
@adonath adonath mentioned this pull request Aug 2, 2022
@bkhelifi bkhelifi deleted the Issue3984 branch August 2, 2022 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Development

Successfully merging this pull request may close these issues.

SafeMaskMaker fails with fixed_offset option
3 participants