New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix the SafeMaskMaker #3987
Fix the SafeMaskMaker #3987
Conversation
…ion to the mask functions
Codecov Report
@@ Coverage Diff @@
## master #3987 +/- ##
==========================================
- Coverage 94.04% 94.04% -0.01%
==========================================
Files 162 162
Lines 21391 21401 +10
==========================================
+ Hits 20118 20127 +9
- Misses 1273 1274 +1
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @bkhelifi!
Main comment here is that tests should be added to ensure the issues are properly corrected and that future changes do not break this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @bkhelifi
Description
This pull request is associated to the issue #3984. It fixes 2 things as discussed during the last dev call
Dear reviewer
This PR is aimed for the bug release V0.20.2