Add 1LHAASO to gammapy.catalog #4595
Conversation
Signed-off-by: <quentin.remy@live.fr>
Signed-off-by: <quentin.remy@live.fr>
Signed-off-by: <quentin.remy@live.fr>
Co-authored-by: Bruno Khélifi <khelifi@in2p3.fr>
Co-authored-by: Bruno Khélifi <khelifi@in2p3.fr>
Signed-off-by: <quentin.remy@live.fr>
Co-authored-by: Atreyee Sinha <asinha@ucm.es>
Signed-off-by: <quentin.remy@live.fr>
There was a problem hiding this comment.
Thanks @QRemy . This looks good. I have left a few minor inline comments.questions.
|
|
||
| errs = { | ||
| "lat_0": pos_err / scale_r95, | ||
| "lon_0": pos_err / scale_r95 / np.cos(lat_0), |
There was a problem hiding this comment.
why is the division by cos(lat) necessary?
There was a problem hiding this comment.
not sure it is the same for 4FGL and 3HWC catalogue.
There was a problem hiding this comment.
I see that this was introduced after issue #2460 . I suppose this implies that the error in the table is given as a proper angular separation and one wants to correct for that. Does this apply all the time?
Co-authored-by: Régis Terrier <regis.terrier@m4x.org>
Codecov Report
@@ Coverage Diff @@
## main #4595 +/- ##
==========================================
+ Coverage 95.05% 95.07% +0.02%
==========================================
Files 221 222 +1
Lines 31573 31723 +150
==========================================
+ Hits 30013 30162 +149
- Misses 1560 1561 +1
... and 7 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Add 1LHAASO catalog class.
This requires to add the catalog FITS file to gammapy-data.