Update 4FGL catalog default to DR4 #4703
Conversation
QRemy
force-pushed
the
catalog_4fgl_dr4_update
branch
from
251b1c1
to
106efa4
Compare
There was a problem hiding this comment.
Thanks @QRemy . Is it possible to add tests using different versions of the release?
gammapy/catalog/fermi.py
Outdated
| source_object_class = SourceCatalogObject4FGL | ||
|
|
||
| def __init__(self, filename="$GAMMAPY_DATA/catalogs/fermi/gll_psc_v28.fit.gz"): | ||
| def __init__(self, filename="$GAMMAPY_DATA/catalogs/fermi/gll_psc_v32.fit"): |
There was a problem hiding this comment.
How about gzipping the file here as well?
There was a problem hiding this comment.
done, also I updated the tests based on DR2&3 to DR4 so we can delete the catalog files from DR2 and DR3 from gammapy-data
There was a problem hiding this comment.
So, the code should be updated after you change, no?
Codecov Report
@@ Coverage Diff @@
## main #4703 +/- ##
==========================================
+ Coverage 75.95% 76.03% +0.07%
==========================================
Files 223 223
Lines 31959 32136 +177
==========================================
+ Hits 24275 24434 +159
- Misses 7684 7702 +18
... and 24 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Signed-off-by: <quentin.remy@live.fr>
Signed-off-by: <quentin.remy@live.fr>
Signed-off-by: <quentin.remy@live.fr>
Signed-off-by: <quentin.remy@live.fr>
Signed-off-by: <quentin.remy@live.fr>
QRemy
force-pushed
the
catalog_4fgl_dr4_update
branch
from
39c1703
to
6abdb6c
Compare
QRemy
added
backport-v1.0.x
|
Regarding the backports: for former versions we use tagged versions of gammapy-data. The changes you introduced should therefore not appear in gammapy-data used by v1.0.x and v1.1.x. |
registerrier
removed
backport-v1.0.x
There was a problem hiding this comment.
Thanks @QRemy. Looks good!
I have removed the backports here.
Update 4FGL catalog default to DR4 and load the correct extended sources file based on the catalog version.
Requires gammapy/gammapy-data#42