Fixed offset calculation in Background2D.to_3d #4728
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: cgalelli <claudio.galelli@obspm.fr>
bkhelifi
reviewed
Aug 25, 2023
Codecov Report
@@ Coverage Diff @@
## main #4728 +/- ##
=======================================
Coverage 76.00% 76.00%
=======================================
Files 223 223
Lines 32018 32019 +1
=======================================
+ Hits 24336 24337 +1
Misses 7682 7682
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Signed-off-by: cgalelli <claudio.galelli@obspm.fr>
bkhelifi
previously approved these changes
Aug 25, 2023
QRemy
reviewed
Aug 28, 2023
QRemy
reviewed
Aug 28, 2023
QRemy
added
backport-v1.0.x
meeseeksmachine
pushed a commit
to meeseeksmachine/gammapy
that referenced
this pull request
Aug 29, 2023
meeseeksmachine
pushed a commit
to meeseeksmachine/gammapy
that referenced
this pull request
Aug 29, 2023
registerrier
added a commit
that referenced
this pull request
Sep 4, 2023
…8-on-v1.0.x Backport PR #4728 on branch v1.0.x (Fixed offset calculation in Background2D.to_3d)
registerrier
added a commit
that referenced
this pull request
Sep 4, 2023
…8-on-v1.1.x Backport PR #4728 on branch v1.1.x (Fixed offset calculation in Background2D.to_3d)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I tried to fix the bug presented in issue #4724 by @maxnoe
Background2D.to_3d was using cartesian offset instead of angular separation. Implemented using
astropy.coordinates.angular_separation