Add a function to delete a time interval from GTI #4822
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: cgalelli <claudio.galelli@obspm.fr>
|
The CI issue is corrected. You can rebase to make it run. |
Codecov Report
@@ Coverage Diff @@
## main #4822 +/- ##
==========================================
+ Coverage 75.52% 75.54% +0.02%
==========================================
Files 224 224
Lines 32771 32804 +33
==========================================
+ Hits 24750 24783 +33
Misses 8021 8021
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Thanks @cgalelli . This looks good!
I think there is one issue because you don't copy the parent Table. You are probably modifying the GTI.
Otherwise you might add a test when the bad interval is partly outside or fully outside the range of your GTI?
gammapy/data/gti.py
Outdated
| interval_start.format = self.time_start.format | ||
| interval_stop.format = self.time_stop.format | ||
|
|
||
| trim_table = self.table |
There was a problem hiding this comment.
Here you are modifying the parent table. You should make a copy to avoid changing the parent GTI.
…touched. Added test for out of scope intervals Signed-off-by: cgalelli <claudio.galelli@obspm.fr>
bkhelifi
reviewed
Oct 19, 2023
Signed-off-by: cgalelli <claudio.galelli@obspm.fr>
registerrier
approved these changes
Oct 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As requested by the issue #4784 I added a function that removes a "bad time interval" from the GTIs with correlated test. A future addition will be a more complex handling of lists of "bad periods"