Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support negative offset for Background2d.to_3d #4978

Merged
merged 3 commits into from Dec 20, 2023
Merged

Conversation

AtreyeeS
Copy link
Member

This fixes #4950

I don't think having the first bin centered on zero is necessarily prevented by the GADF, so I just adapted the to_3d function

@AtreyeeS AtreyeeS added the bug label Dec 12, 2023
@AtreyeeS AtreyeeS added this to To do in gammapy.irf via automation Dec 12, 2023
@AtreyeeS AtreyeeS added this to the 1.0.3 milestone Dec 12, 2023
Copy link

codecov bot commented Dec 12, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (4e49533) 75.71% compared to head (4059606) 75.71%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4978   +/-   ##
=======================================
  Coverage   75.71%   75.71%           
=======================================
  Files         228      228           
  Lines       33775    33778    +3     
=======================================
+ Hits        25573    25576    +3     
  Misses       8202     8202           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@AtreyeeS AtreyeeS added backport-v1.0.x on-merge: backport to v1.0.x backport-v1.1.x on-merge: backport to v1.1.x labels Dec 12, 2023
@AtreyeeS AtreyeeS modified the milestones: 1.0.3, 1.2 Dec 12, 2023
@QRemy QRemy added backport-v1.0.x on-merge: backport to v1.0.x and removed backport-v1.0.x on-merge: backport to v1.0.x labels Dec 20, 2023
@QRemy QRemy self-assigned this Dec 20, 2023
@QRemy QRemy self-requested a review December 20, 2023 11:30
AtreyeeS and others added 3 commits December 20, 2023 13:34
Signed-off-by: Atreyee Sinha <asinha@ucm.es>
Signed-off-by: Atreyee Sinha <asinha@ucm.es>
Signed-off-by: Quentin Remy <quentin.remy@mpi-hd.mpg.de>
@QRemy QRemy merged commit 921f1a9 into gammapy:main Dec 20, 2023
15 checks passed
gammapy.irf automation moved this from To do to Done Dec 20, 2023
Copy link

lumberbot-app bot commented Dec 20, 2023

Owee, I'm MrMeeseeks, Look at me.

There seem to be a conflict, please backport manually. Here are approximate instructions:

  1. Checkout backport branch and update it.
git checkout v1.0.x
git pull
  1. Cherry pick the first parent branch of the this PR on top of the older branch:
git cherry-pick -x -m1 921f1a9d3b5400e02968b78cf264ad9154840c10
  1. You will likely have some merge/cherry-pick conflict here, fix them and commit:
git commit -am 'Backport PR #4978: Support negative offset for Background2d.to_3d'
  1. Push to a named branch:
git push YOURFORK v1.0.x:auto-backport-of-pr-4978-on-v1.0.x
  1. Create a PR against branch v1.0.x, I would have named this PR:

"Backport PR #4978 on branch v1.0.x (Support negative offset for Background2d.to_3d)"

And apply the correct labels and milestones.

Congratulations — you did some good work! Hopefully your backport PR will be tested by the continuous integration and merged soon!

Remember to remove the Still Needs Manual Backport label once the PR gets merged.

If these instructions are inaccurate, feel free to suggest an improvement.

Copy link

lumberbot-app bot commented Dec 20, 2023

Owee, I'm MrMeeseeks, Look at me.

There seem to be a conflict, please backport manually. Here are approximate instructions:

  1. Checkout backport branch and update it.
git checkout v1.1.x
git pull
  1. Cherry pick the first parent branch of the this PR on top of the older branch:
git cherry-pick -x -m1 921f1a9d3b5400e02968b78cf264ad9154840c10
  1. You will likely have some merge/cherry-pick conflict here, fix them and commit:
git commit -am 'Backport PR #4978: Support negative offset for Background2d.to_3d'
  1. Push to a named branch:
git push YOURFORK v1.1.x:auto-backport-of-pr-4978-on-v1.1.x
  1. Create a PR against branch v1.1.x, I would have named this PR:

"Backport PR #4978 on branch v1.1.x (Support negative offset for Background2d.to_3d)"

And apply the correct labels and milestones.

Congratulations — you did some good work! Hopefully your backport PR will be tested by the continuous integration and merged soon!

Remember to remove the Still Needs Manual Backport label once the PR gets merged.

If these instructions are inaccurate, feel free to suggest an improvement.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-v1.0.x on-merge: backport to v1.0.x backport-v1.1.x on-merge: backport to v1.1.x bug Still Needs Manual Backport
Projects
gammapy.irf
  
Done
Development

Successfully merging this pull request may close these issues.

Offset axis calculated from fov lon/lat axis can contain a negative bin
3 participants