Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add degrees of freedom on FluxMaps #5040

Merged
merged 4 commits into from Jan 23, 2024
Merged

Add degrees of freedom on FluxMaps #5040

merged 4 commits into from Jan 23, 2024

Conversation

AtreyeeS
Copy link
Member

This PR adds n_dof as an optional valid quantity on FluxMaps as discussed on #5007

@AtreyeeS
first commit
75d87eb 
Signed-off-by: Atreyee Sinha <asinha@ucm.es>
@AtreyeeS
add test
a202a4f 
Signed-off-by: Atreyee Sinha <asinha@ucm.es>
@AtreyeeS
add in docs
9bd7f8a 
Signed-off-by: Atreyee Sinha <asinha@ucm.es>
@AtreyeeS AtreyeeS added this to In progress in gammapy.estimators via automation Jan 23, 2024
@AtreyeeS AtreyeeS added this to the 1.2 milestone Jan 23, 2024
@codecov Codecov
Copy link

codecov bot commented Jan 23, 2024 •
edited

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (6321261) 75.71% compared to head (58f162d) 75.45%.
Report is 78 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #5040      +/-   ##
==========================================
- Coverage   75.71%   75.45%   -0.26%     
==========================================
  Files         229      230       +1     
  Lines       33846    34103     +257     
==========================================
+ Hits        25626    25732     +106     
- Misses       8220     8371     +151

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

cgalelli
cgalelli previously approved these changes Jan 23, 2024
View reviewed changes
Copy link
Contributor

@cgalelli cgalelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the addition @AtreyeeS ! No comments on my side

adonath
adonath reviewed Jan 23, 2024
View reviewed changes
Copy link
Member

@adonath adonath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @AtreyeeS! I have left one suggestion.

@AtreyeeS @adonath
Update gammapy/estimators/map/core.py
58f162d 
Co-authored-by: Axel Donath <adonath@users.noreply.github.com>
adonath
adonath approved these changes Jan 23, 2024
View reviewed changes
Copy link
Member

@adonath adonath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I have no further comments!

@AtreyeeS AtreyeeS merged commit 58d7aa6 into gammapy:main Jan 23, 2024
14 of 16 checks passed
gammapy.estimators automation moved this from In progress to Done Jan 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adonath adonath adonath approved these changes

@cgalelli cgalelli cgalelli approved these changes

@registerrier registerrier Awaiting requested review from registerrier

Assignees
No one assigned
Labels
feature
Projects
gammapy.estimators
  
Done
Milestone
1.2
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@AtreyeeS @adonath @cgalelli