Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve PointingInfo class #548

Closed
6 tasks
cdeil opened this issue Jun 3, 2016 · 1 comment
Closed
6 tasks

Improve PointingInfo class #548

cdeil opened this issue Jun 3, 2016 · 1 comment
Assignees
Labels
Milestone

Comments

@cdeil
Copy link
Contributor

cdeil commented Jun 3, 2016

In #545 I added a PointingInfo class.

It is unfinished, the following additions should be made in a follow-up pull requests (not all at once ... incremental improvements are needed here):

  • Link to spec (when available)
  • Correct test with HESS (when differences understood)
  • Add interpolation method to get RA / DEC and ALT / AZ at arbitrary times.
  • Refactor to avoid duplicated code with the EventList and ObservationTable classes?
  • Integrate with DataStore
  • Use in high-level IACT analysis code
@cdeil cdeil added the feature label Jun 3, 2016
@cdeil cdeil added this to the 0.5 milestone Jun 3, 2016
@cdeil cdeil modified the milestones: 0.6, 0.5 Jul 7, 2016
@cdeil cdeil modified the milestones: 0.6, 0.7 Jan 27, 2017
@cdeil cdeil modified the milestones: 0.7, 0.8 Sep 14, 2017
@cdeil cdeil modified the milestones: 0.8, 0.9 May 3, 2018
@cdeil cdeil added this to To do in gammapy.data via automation Jul 15, 2018
@cdeil cdeil modified the milestones: 0.9, 0.8 Jul 15, 2018
@cdeil cdeil self-assigned this Jul 15, 2018
@cdeil
Copy link
Contributor Author

cdeil commented Jul 15, 2018

Closing this old issue. Half of the tasks above are done. The class is currently in pretty good shape, and anyways it's still unused. If we start using it in the future (e.g. for slowing observations, or for CTA), we can improve it further, but this old issue won't help.

@cdeil cdeil closed this as completed Jul 15, 2018
gammapy.data automation moved this from To do to Done Jul 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
gammapy.data
  
Done
Development

No branches or pull requests

1 participant