Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update EffectiveAreaTable2d to read effective area as function of reconstructed energy #757

Closed
joleroi opened this issue Nov 8, 2016 · 4 comments
Closed

Update EffectiveAreaTable2d to read effective area as function of reconstructed energy #757

joleroi opened this issue Nov 8, 2016 · 4 comments
Labels
effort-low
Milestone
0.6

Comments

@joleroi
Copy link
Contributor

joleroi commented Nov 8, 2016

The EffectiveAreaTable2d.read method at the moment takes the first HDU it find. As of https://github.com/gammasky/hess-host-analyses/issues/48 there is a second HDU containing the effective area as a function of reconstructed energy. It should be possible to read this HDU.
@joleroi joleroi added this to the 0.6 milestone Nov 8, 2016
@cdeil
Copy link
Contributor

cdeil commented Nov 9, 2016

Related:

Agreed this should be changed so that a hdu option works for EffectiveAreaTable2d.read.

@joleroi
Copy link
Contributor Author

joleroi commented Nov 10, 2016 •
edited

Actually I think nothing has to be done, since Table.read takes hdu as keyword argument. Or even an HDU object (see comment you linked to)

@joleroi
Copy link
Contributor Author

joleroi commented Nov 11, 2016

This should be fixed by #755

@joleroi
Copy link
Contributor Author

joleroi commented Jan 10, 2017

This was fixed in #832

@joleroi joleroi closed this as completed Jan 10, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
effort-low
Projects
None yet
Milestone
0.6
Development

No branches or pull requests
2 participants
@cdeil @joleroi