Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve differential flux point computation code #812

Merged
merged 3 commits into from Dec 10, 2016
Merged

Improve differential flux point computation code #812

merged 3 commits into from Dec 10, 2016

Conversation

adonath
Copy link
Member

@adonath adonath commented Dec 8, 2016

This PR renames compute_differential_flux_points to compute_flux_points_dnde and makes it compatible with the new FluxPoints class.

@adonath adonath added this to the 0.6 milestone Dec 8, 2016
@adonath adonath self-assigned this Dec 8, 2016
@cdeil
Copy link
Contributor

cdeil commented Dec 8, 2016

@adonath - The diff is very large and hard to review.

If you want me to have a look, let me know.

Otherwise, there's this one fail that should probably be resolved before merging?
https://travis-ci.org/gammapy/gammapy/jobs/182366502#L1800

@adonath adonath merged commit 73179f7 into gammapy:master Dec 10, 2016
@cdeil cdeil changed the title Rewrite compute differential flux points method Improve differential flux point computation code Dec 12, 2016
@adonath adonath deleted the rewrite_compute_differential_flux_points branch November 20, 2018 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@adonath adonath

Labels
cleanup feature
Projects
None yet
Milestone
0.6
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@adonath @cdeil