Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow users to modify attributes of the tracking cookie #305

Merged
merged 1 commit into from
Apr 24, 2024

Conversation

mjkrivacek
Copy link
Contributor

Description, Motivation and Context

When using the Nexus Websockets tracking cookie option it might be necessary to modify the cookie attributes. This is helpful when using Nexus WAMP over Websockets from a Web browser. Web browsers vary on the handling of cookies received.

What is the current behavior?

RESOLVES #295

What is the new behavior?

This change exposes two new websocket server settings that can be modified by the user. These settings control which SameSite mode that the nexus-wamp-cookie will be sent back with. Further, it allows the user to set the Secure attribute of the cookie to restrict the cookie to secure connections.

What kind of change does this PR introduce?

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the code style of this project.
  • I have added tests to cover my changes.
  • Overall test coverage is not decreased.
  • All new and existing tests passed.
  • My change requires a change to the documentation.
    • I have updated the documentation accordingly.

(this is my first attempt at a PR of any kind. Please let me know what I might have missed)

Copy link
Collaborator

@KSDaemon KSDaemon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mjkrivacek Great! Everything looks good: code, tests, pr description! Thank you for you contribution! 👍🏻

@gammazero gammazero merged commit dd076ea into gammazero:v3 Apr 24, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Modify WebsocketServer Tracking Cookie Attributes
3 participants