Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix progressive calls: remove options in subsequent calls #307

Merged
merged 2 commits into from
Jan 15, 2024

Conversation

KSDaemon
Copy link
Collaborator

Description, Motivation and Context

The WAMP Spec defines that all options except progress should be removed from subsequent progressive call messages on the Caller and/or Dealer sides. This PR syncs nexus logic with the spec.

Refs wamp-proto/wamp-proto#511
See WAMP Spec section for details.

What kind of change does this PR introduce?

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the code style of this project.
  • I have added tests to cover my changes.
  • Overall test coverage is not decreased.
  • All new and existing tests passed.
  • My change requires a change to the documentation.
    • I have updated the documentation accordingly.

@KSDaemon KSDaemon mentioned this pull request Nov 29, 2023
9 tasks
@KSDaemon
Copy link
Collaborator Author

KSDaemon commented Dec 7, 2023

@gammazero gentle ping here....

@KSDaemon KSDaemon merged commit de35d17 into v3 Jan 15, 2024
6 checks passed
@KSDaemon
Copy link
Collaborator Author

Okay... I'll merge it.

@KSDaemon KSDaemon deleted the progressive-calls-fix branch January 15, 2024 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant