Moved Twitter consumer key & secret from source to environment variables #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…variables and modified README to reflect new instructions
ganarajpr
added a commit
that referenced
this pull request
Apr 14, 2013
Moved Twitter consumer key & secret from source to environment variables
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think it is a safer practice to store the authentication credentials in environment variables rather than hard coded in the source (which may even be stored in a public repository).
Also, I modified the README to have a little more information about setting up the environment once cloned and an alternative way to run the app.
(BTW, if you accept this pull request, I would like to make more contributions as well. I think node on the backend and Angular on the front-end is a clean approach when you want to support multiple UI front-ends such as web, iOS, and Android)