Fix: GetNamespace no longer checks if class|interface|trait is defined

ganbarodigital · Sep 17, 2017 · e84176a · e84176a
1 parent eac156a
commit e84176a
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 29 deletions.
diff --git a/docs/changelog.md b/docs/changelog.md
@@ -156,6 +156,10 @@
   - added `Error`
   - added `TypeError`
 
+### Fixes
+
+* `GetNamespace` no longer cares if the class|interface|trait name has been declared to PHP
+
 ### Refactor
 
 Before refactoring, we checked Packagist to make sure that these changes would not break anything that depends upon The Missing Bits.

diff --git a/src/TypeInspectors/GetNamespace.php b/src/TypeInspectors/GetNamespace.php
@@ -91,11 +91,6 @@ public static function from($item)
             throw new InvalidArgumentException("\$item must be an object, or a class/interface/trait name");
         }
 
-        // make sure we have something we can work with
-        if (!class_exists($item) && !interface_exists($item) && !trait_exists($item)) {
-            throw new InvalidArgumentException("{$item} is not a declared class");
-        }
-
         // okay, what do we have?
         $pos = strrpos($item, '\\');
         if ($pos) {

diff --git a/tests/TypeInspectors/GetNamespaceTest.php b/tests/TypeInspectors/GetNamespaceTest.php
@@ -205,30 +205,6 @@ public function testReturnsEmptyStringForClassesWithNoNamespace($data, $expected
         $this->assertEquals($expectedNamespace, $actualNamespace);
     }
 
-    /**
-     * @covers ::getNamespace
-     * @covers ::from
-     * @dataProvider provideNonDefinedClassesToTest
-     * @expectedException InvalidArgumentException
-     */
-    public function test_throws_InvalidArgumentException_if_class_not_defined($data)
-    {
-        // ----------------------------------------------------------------
-        // setup your test
-
-        $this->assertTrue(is_string($data));
-        $unit = new GetNamespace();
-
-        // ----------------------------------------------------------------
-        // perform the change
-
-        $unit->getNamespace($data);
-
-        // ----------------------------------------------------------------
-        // test the results
-
-    }
-
     /**
      * @covers ::getNamespace
      * @covers ::from