Uninitialised and unused variables #136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… (N.B. uses C-style casts) [Manual re-do of commit cd742f1..]
|
For me it's fine. The previous pull request has introduced a conflict which I am going to take care of (and I will also get rid of some commented code). |
…it's properly been calculated in ExactReimannSolver
…some ionisation routines that will be addressed in a future commit). Also cleaned up some code, indents, removing tabs, etc..
giovanni-rosotti
force-pushed
the
init_variables5
branch
from
23be2e0
to
798d493
Compare
|
Rebase done - wait for my commit now |
|
Assuming this passes travis, I'm happy for it to go. |
|
Done. Richard, you should have the honour of merging the pull request as both David and I have been involved in the pull request. |
|
Ummmm, did you just close this branch without merging it Richard??
…On 24 March 2017 at 21:04, Richard Booth ***@***.***> wrote:
Closed #136 <#136>.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#136 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AEsg1Zg6GdGzJ4XoNM7JDWWR4Thy-Ozcks5rpCHSgaJpZM4MoQ-H>
.
|
|
Looks like it...
…On 24/03/17 20:06, dhubber wrote:
Ummmm, did you just close this branch without merging it Richard??
On 24 March 2017 at 21:04, Richard Booth ***@***.***> wrote:
> Closed #136 <#136>.
>
> —
> You are receiving this because you authored the thread.
> Reply to this email directly, view it on GitHub
> <#136 (comment)>,
or mute
> the thread
>
<https://github.com/notifications/unsubscribe-auth/AEsg1Zg6GdGzJ4XoNM7JDWWR4Thy-Ozcks5rpCHSgaJpZM4MoQ-H>
> .
>
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
<#136 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AOqItHagbWY6L2kQjZMvvxr_fwvRz4vhks5rpCJSgaJpZM4MoQ-H>.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Newer version of previous uninitialised variables pull request. Cherry-picked from old branch onto newer up-to-date branch from master. In summary includes :
Also given the code another sweep for newly introduced unused/uninitialised variables. The only exceptions are the MultipleSourceIonisation.cpp and TreeRay.cpp files, which will be dealt with in a future pull request. Hopefully this can be merged quickly before it goes out-of-date (again) with the master branch.