Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"No symbols found" in .jsx files #4

Closed
rgrove opened this issue May 10, 2015 · 5 comments
Closed

"No symbols found" in .jsx files #4

rgrove opened this issue May 10, 2015 · 5 comments

Comments

@rgrove
Copy link

rgrove commented May 10, 2015

When editing a .jsx file, the symbols view (Cmd-R) is empty and displays the message "No symbols found". If I rename the same file to .js, the symbols view displays all the symbols I would expect it to. I've tried a variety of files, and it doesn't seem to be related to the contents at all; just the extension.

(Other than this minor issue, I'm really loving this syntax! Thanks for putting it together.)

@gandm
Copy link
Owner

gandm commented May 11, 2015

I will change the grammar to scope to .jsx. This should allow the builtin Atom symbols for JavaScript to work for all my supported filetypes. The symbols regex provided with Atom needs to be updated to see ES6 structures so it may be of limited use!

@gandm gandm closed this as completed in f0b1215 May 11, 2015
@rgrove
Copy link
Author

rgrove commented May 11, 2015

Hmm. This fixed the symbols view, but broke the linter-eslint package, which will only run ESLint on source.js, source.js.jsx, or source.babel.

@gandm
Copy link
Owner

gandm commented May 11, 2015

OK I've just looked at the source for linter-eslint. Yes It seems they changed it to accommodate source.babel - very kind of them. But they don't support .jsx which is one of the options the Atom symbols package supports. I'll modify my code to change the scopeName to .js.jsx. That should make everyone happy unless someone else is using source.babel!!!!

@gandm gandm reopened this May 11, 2015
@gandm
Copy link
Owner

gandm commented May 11, 2015

@rgrove. Just changed the scopeName to .js.jsx. This is supported by linter so can you check this and the symbols still work.

@rgrove
Copy link
Author

rgrove commented May 11, 2015

Thanks! Works great now.

@gandm gandm closed this as completed May 11, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants