Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Labels are incorrectly highlighten when there is no semi #409

Closed
ooflorent opened this issue Aug 31, 2017 · 5 comments
Closed

Labels are incorrectly highlighten when there is no semi #409

ooflorent opened this issue Aug 31, 2017 · 5 comments

Comments

@ooflorent
Copy link

semi_label

In the above example, x is the second function should also be colored in green.

@gandm
Copy link
Owner

gandm commented Aug 31, 2017

Yeah, actually both are incorrect -I don't handle labels at all! I've had this in the back of my mind to fix but to be frank it's a bit of a pain to do.

gandm pushed a commit that referenced this issue Sep 3, 2017
Issue #409
Fails on labels followed by braces
a: {
 statements...
}
as this may be a flow object def.
@gandm
Copy link
Owner

gandm commented Sep 3, 2017

@ooflorent If you get a chance can you try the latest master in this repo.

// It should work for labels 
label: for() {}
label: while {}
label: do {}
label:
{
   statements
}
// BUT NOT
label: { // ambiguous as this could be a flow def of an object
   statements 
}

@gandm
Copy link
Owner

gandm commented Sep 5, 2017

This change is in 2.74.0

@gandm gandm closed this as completed Sep 5, 2017
@ooflorent
Copy link
Author

It works like a charm! Thanks

@gandm
Copy link
Owner

gandm commented Sep 5, 2017

Just saw an issue with break|continue labelname that is fixed in 2.74.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants