Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

styled-components support breaks highlighting #424

Closed
ooflorent opened this issue Oct 3, 2017 · 3 comments
Closed

styled-components support breaks highlighting #424

ooflorent opened this issue Oct 3, 2017 · 3 comments

Comments

@ooflorent
Copy link

When using SC without tagged template string, the syntax coloring is broken.

sc

@gandm
Copy link
Owner

gandm commented Oct 3, 2017

I have fixed this in my local grammar but I don't think the above syntax is sound. I believe it should be terminated with an empty template string. I'm not using styled-components but I did a quick experiment and seemed to get strange results without a null string. Also see styled-components/styled-components#1124 (comment)

@ooflorent
Copy link
Author

Many thanks. While the pattern is not commonly used, it is documented and used in libraries.

@gandm
Copy link
Owner

gandm commented Oct 4, 2017

Still don't think it's correct just because it is equivalent. The example in the library is OK because of line 64, so the function chain isn't broken. Anyway, it should work for you now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants