Here is how things would work if this were its own package. #85

bolinfest · 2015-09-23T16:46:02Z

On my machine (with all of Nuclide installed), here is what timecop looks like before this change:

And here is what timecop looks like after this change:

There is a dramatic difference in load time if this could be split out into a package that were only the grammar.

Without even testing, I'm 99% sure the reason why line-ending-selector is in that list is because of this line:

https://github.com/atom/line-ending-selector/blob/54c23121ae8ba18ba3992a4ccceda44b750b6fe8/lib/main.js#L3

In Nuclide, you can see that we don't allow any of our packages to depend on lodash, q, or underscore because we have found that they have a serious negative effect on load times:

https://github.com/facebook/nuclide/blob/e961c4d3461c3abc35a6f8ccaf3f6e959b622f1e/scripts/lib/package_linter.py#L21-L27

Here is how things would work if this were its own package.

cb2e19e

bolinfest mentioned this pull request Sep 23, 2015

Request: separate version of the plugin that is just the grammar #64

Closed

gandm closed this Sep 23, 2015

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Here is how things would work if this were its own package. #85

Here is how things would work if this were its own package. #85

bolinfest commented Sep 23, 2015

Here is how things would work if this were its own package. #85

Here is how things would work if this were its own package. #85

Conversation

bolinfest commented Sep 23, 2015