Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Jira Bug I7-2460 #138

Merged
merged 1 commit into from Apr 5, 2024
Merged

Fix Jira Bug I7-2460 #138

merged 1 commit into from Apr 5, 2024

Conversation

neroden
Copy link
Contributor

@neroden neroden commented Jan 30, 2024

https://inform7.atlassian.net/jira/software/c/projects/I7/issues/I7-2460?filter=updatedrecently

This allows the sensible error messages from "remove" to trigger rather than giving strange "you can't see any such thing" errors.

@neroden
Copy link
Contributor Author

neroden commented Feb 3, 2024

The first version of this didn't work right and broke a bunch of stuff, due to some important things I overlooked when trying to convert it from an extension to a patch (which is an error-prone process).

The new version doesn't break anything. It fixes the error message for the single-item case ("REMOVE CAT FROM BOX" where the cat is in the room but not in the box), which is by far the most common case, and at least means that the error message in Standard Rules gets printed sometimes (rather than never ever being used, which is the situation without any patch).

The multi-item case ("REMOVE CAT AND DOG FROM BOX") is too hairy to handle at this time and still gives "You can't see any such thing". This is largely due to the amount of special casing of ##Remove in the I6 parser, and the inaccessibility of the look-forward code to any token other than multiinside and multiexcept. (I may approach it again after I've figured out how to make the look-forward code accessible to the "deciding whether all includes" activity.)

@ganelson ganelson merged commit efc18df into ganelson:master Apr 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants