Copy hmac.key to new nodes #1494
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saschalucas
approved these changes
Jul 3, 2020
There was a problem hiding this comment.
Thanks a lot for spotting this out. I have verified, that mond and confd complain about missing hmac.key right after gnt-node add and therefore fails to start initially. The noded will install hmac.key later via RPC calls during node setup. Then these daemons can be started by the watcher. This PR makes these daemons start properly (again).
Signed-off-by: Klaus Aehlig <aehlig@google.com> Reviewed-by: Petr Pudlak <pudlak@google.com> (cherry picked from commit c99ad7b)
The function extracts the hmac key from the provided initial data; it also raises an appropriate error if the key is not provided. Signed-off-by: Klaus Aehlig <aehlig@google.com> Reviewed-by: Petr Pudlak <pudlak@google.com> (cherry picked from commit cd58e9e)
On setting up a node, initial data is shipped via ssh to the target node, so that the node daemon can run properly to take on the remaining configuration tasks via RPC. At that point, also other daemons, including the monitoring daemon (if enabled) are started. Therefore, also ship the hmac key file as part of the initial data, as the monitoring daemon needs it for confd queries. Signed-off-by: Klaus Aehlig <aehlig@google.com> Reviewed-by: Petr Pudlak <pudlak@google.com> (cherry picked from commit 4f3b030)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
This is a cherry-pick of three commits (c99ad7b, ab92101, 4f3b030) from stable-2.17 that went missing as part of #1328. They are marked as TODO in https://github.com/ganeti/ganeti/wiki/AtticMasterCherrypicks.
It fixes #1182 (again).