Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent the flask server from starting during shutdown #1971

Merged
merged 1 commit into from
Aug 13, 2021
Merged

Conversation

egede
Copy link
Member

@egede egede commented Aug 13, 2021

The flask server was started during the import of a module. So when running ganga without the GUI starting the following happened.

  • At startup, the flask server was not started
  • At shutdown the GUI module was imported to check if the flask server was running. But this CAUSED the flask server to start.

A new module is now used as a singleton object to keep the state in.

@egede egede merged commit 13c3c2c into develop Aug 13, 2021
@egede egede deleted the clean-shutdown branch August 13, 2021 07:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants