-
Notifications
You must be signed in to change notification settings - Fork 99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/monitor heartbeat checking #200
Conversation
In principle I'm happy for this to be merged. I'll need to review the code first but then we should be good. |
Is it easy to make the 180 s configurable? Just in case we figure out that it is too short and that users get flooded with fake positives. |
@egede I'll get on that now before I push to merge the PR, we may keep it at 5min or higher for 6.1.16 while it's in testing |
I guess a config item in |
OK, should be configurable now, and set to 300s by default. |
I think this should be fixed for merging? |
👍 |
Feature/monitor heartbeat checking
This branch attempts to pull out the heartbeat code from #182 as it's likely that this branch could be superseded by other code due to work performed elsewhere.
This PR includes the code to inform the user if a worker thread is working and has been performing the same task for > 3min.
This 3min is currently not user configurable and is hard-coded as 180.
This PR also includes some very minor changes to improve the shutdown of the Monitoring loop at the end of it's life and some minor changes relating to the construction/teardown of the thread-pool which effects the GangaUnitTests derived tests as well as elsewhere.
This has already been discussed for inclusion in 6.1.16.