Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor out dependency on execute utility #2176

Merged
merged 5 commits into from Aug 14, 2023
Merged

Refactor out dependency on execute utility #2176

merged 5 commits into from Aug 14, 2023

Conversation

shalearkane
Copy link
Collaborator

@shalearkane shalearkane commented Jul 10, 2023 •
edited

Fixes #2105

Right now, it just removes the use of execute utility except for these cases:

  1. DiracUtilities.execute uses the python_setup feature
  2. DiracUtilities.get_env uses the update_env feature

It also removes the old timer code with a modern equivalent and the eval_includes functionality.

@shalearkane shalearkane marked this pull request as ready for review August 1, 2023 12:13
@shalearkane
Refactor out dependency on execute utility
8106a4e 
Signed-off-by: Soumik Dutta <shalearkane@gmail.com>
@shalearkane
remove testcases for eval_includes
8d513d2 
Signed-off-by: Soumik Dutta <shalearkane@gmail.com>
@shalearkane
remove all references to eval_includes
6890393 
Signed-off-by: Soumik Dutta <shalearkane@gmail.com>
ganga-ci and others added 2 commits August 14, 2023 19:02
@ganga-ci @shalearkane
PEP8 fixes for PR #2176 (feat2105-replace-execute) by autopep8 (#2177)
9997566 
* autopep8 action fixes

* fix linting errors

Signed-off-by: Soumik Dutta <shalearkane@gmail.com>

---------

Signed-off-by: Soumik Dutta <shalearkane@gmail.com>
Co-authored-by: shalearkane <shalearkane@users.noreply.github.com>
Co-authored-by: Soumik Dutta <shalearkane@gmail.com>
@egede
Merge branch 'develop' into feat2105-replace-execute
f3fe871
egede
egede approved these changes Aug 14, 2023
View reviewed changes
Copy link
Member

@egede egede left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works all good in my testing

@egede egede merged commit da620e6 into develop Aug 14, 2023
9 of 10 checks passed
@egede egede deleted the feat2105-replace-execute branch August 14, 2023 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@egede egede egede approved these changes

@mesmith75 mesmith75 Awaiting requested review from mesmith75

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Refactor use of shell command
3 participants
@shalearkane @egede @ganga-ci