Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix removeLFNs #2186

Merged
merged 4 commits into from Aug 21, 2023
Merged

fix removeLFNs #2186

merged 4 commits into from Aug 21, 2023

Conversation

mesmith75
Copy link
Contributor

Fixes #2185

egede
egede reviewed Aug 15, 2023
View reviewed changes
Copy link
Member

@egede egede left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is the credential requirement for this function (and the others that are exported to the GPI) None? Should it not be DiracProxy?

@mesmith75
Copy link
Contributor Author

I think the point is that normally the credential is associated with the backend whereas these are standalone functions.

@mesmith75 mesmith75 merged commit 9d1e047 into develop Aug 21, 2023
10 checks passed
@mesmith75 mesmith75 deleted the removeLFN_fix branch August 21, 2023 08:38
mesmith75 added a commit that referenced this pull request Aug 21, 2023
@mesmith75
Merge pull request #2187 from ganga-devs/autopep8-patches/removeLFN_fix
9f5fc39 
PEP8 fixes for PR #2186 (removeLFN_fix) by autopep8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@egede egede egede approved these changes

@alexanderrichards alexanderrichards Awaiting requested review from alexanderrichards

Assignees
No one assigned
Labels
bug DIRAC
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Dirac removeLFNs is broken
2 participants
@mesmith75 @egede