Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix issues with some malfunctioning docker commands (#2309) #2314

Merged
merged 5 commits into from Apr 15, 2024

Conversation

dg1223
Copy link
Contributor

@dg1223 dg1223 commented Mar 30, 2024

The following Docker commands now work correctly:

d = Docker()
d = Docker('fedora:latest')
d = Docker(image='fedora:latest')
d = Docker(image='fedora:latest', mode='P1')

In addition, added unit tests for each of these commands.

Please note that this fix does not remove the __init__ function from Docker,py as suggested here. Instead, it sets default values for the image and mode parameters in the __init__ function in Docker.py.

@egede egede temporarily deployed to Integrate Pull Request April 10, 2024 01:07 — with GitHub Actions Inactive
@egede
Copy link
Member

egede commented Apr 10, 2024

@dg1223 Thanks for adding the test cases as well.

@dg1223
Copy link
Contributor Author

dg1223 commented Apr 12, 2024

@dg1223 Thanks for adding the test cases as well.

No problem at all!

@mesmith75 mesmith75 temporarily deployed to Integrate Pull Request April 15, 2024 08:50 — with GitHub Actions Inactive
@mesmith75 mesmith75 merged commit b0a6744 into ganga-devs:develop Apr 15, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants