Remove unwanted traces and fix registryslice summary #713
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hey're not needed
…hey're not needed
…ly hide objects marked as Incomplete during runtime
|
retest this please |
|
Any objections to merging this? |
|
Rats forgot to mark this for inclusion before 6.2.0, 6.2.1 will have to be good enough although it improves the experience of users on the IPython prompt imo. |
|
Any objections to merging this? |
rob-c
added a commit
that referenced
this pull request
Sep 16, 2016
* Fixing treatment of not found attributes to avoid stack traces when they're not needed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses 2 areas where stack traces are generated within the IPython prompt that aren't particularly wanted/required.
The 2 stack traces I'm looking to avoid here are, 1) mis-typed commands from the IPython prompt, and 2) attributes not being found from in front of the Proxy.
Fixes #709
I've also added a small fix which removes empty objects from the _display method for objects which have been marked as incomplete during runtime. (I think this effects very few users).