Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some fixes to LHCbDataset #856

Merged
merged 1 commit into from
Nov 7, 2016
Merged

Some fixes to LHCbDataset #856

merged 1 commit into from
Nov 7, 2016

Conversation

mesmith75
Copy link
Contributor

@mesmith75 mesmith75 commented Nov 5, 2016 •
edited

This fixes some issues in LHCbDataset #855 . The difference, symmetricDifference and union functions were calling extend() with a [list(set)]. So the set was being changed to a list but then put inside another list which was causing problems.

I think this is just a hangover from when the code was changed to use extend instead of the now-defunct construct function.

@mesmith75 mesmith75 added this to the 6.2.3 milestone Nov 5, 2016
egede
egede approved these changes Nov 6, 2016
View reviewed changes
Copy link
Member

@egede egede left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@thotava Would it be possible for you to add some unit tests in this area to protect against problems like this in the future.

@mesmith75
Copy link
Contributor Author

If there are no objections I'll merge this...

@mesmith75 mesmith75 merged commit ab4c2ae into develop Nov 7, 2016
@mesmith75 mesmith75 deleted the fileDiffFix branch November 7, 2016 12:54
This was referenced Nov 7, 2016
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@egede egede egede approved these changes

@alexanderrichards alexanderrichards alexanderrichards approved these changes

Assignees
No one assigned
Labels
bug LHCb
Projects
None yet
Milestone
6.2.3
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mesmith75 @egede @alexanderrichards