Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Selecting a portion of a graph doesn't deal well with timezones #38

Closed
maplebed opened this issue Feb 7, 2012 · 2 comments · Fixed by #39
Closed

Selecting a portion of a graph doesn't deal well with timezones #38

maplebed opened this issue Feb 7, 2012 · 2 comments · Fixed by #39
Assignees

Comments

@maplebed
Copy link
Contributor

maplebed commented Feb 7, 2012

When I select a portion of a graph to zoom in on that time slice, the time displayed is off by 8 hours. Conveniently, my ganglia server is running in UTC and I am in the Pacific time zone at UTC-8.

Example: http://screencast.com/t/UJOM9eEgWj - I select from just before noon to just after 1pm (13:00) and the resulting graph displays from just before 20:00 to just after 21:00. I'm not sure what the data it's showing is actually representing; this doesn't only work >12hrs before now(). I'm not sure if the displayed time is incorrect or if it's the data that's incorrect.

You can recreate this for yourself at http://ganglia.wikimedia.org/latest/?c=Swift%20pmtpa&m=load_one&r=hour&s=by%20name&hc=4&mc=2. We are running v2.2.0 of the web interface.

@vvuksan
Copy link
Member

vvuksan commented Feb 7, 2012

We are aware of the issue. Working on troubleshooting it.

@ghost ghost assigned alexdean Feb 7, 2012
@alexdean
Copy link
Member

alexdean commented Feb 7, 2012

This solves the issue for me: eabea48

I don't understand the reasoning behind the previous algorithm, so I'm afraid I'm missing something. I tested w/ varying browser & server time offsets from UTC and this code was correct in the cases I thought of.

@alexdean alexdean closed this as completed Feb 7, 2012
jiongle1 pushed a commit to scantist-ossops-m2/ganglia-web that referenced this issue Apr 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants