Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

check_metric.php does not honor the host parameter #49

Closed
scottbessler opened this issue Mar 6, 2012 · 2 comments
Closed

check_metric.php does not honor the host parameter #49

scottbessler opened this issue Mar 6, 2012 · 2 comments

Comments

@scottbessler
Copy link
Contributor 

# php -v
PHP 5.3.3 (cli) (built: Feb  2 2012 23:47:49) 
Copyright (c) 1997-2010 The PHP Group
Zend Engine v2.3.0, Copyright (c) 1998-2010 Zend Technologies

https://github.com/ganglia/ganglia-web/blob/master/nagios/check_metric.php#L55

re-uses $host as a loop variable and reassigns the value that was set here:

https://github.com/ganglia/ganglia-web/blob/master/nagios/check_metric.php#L22

causing check_metric to use first host no matter what host you send it.
scottbessler pushed a commit to scottbessler/ganglia-web that referenced this issue Mar 6, 2012
fix ganglia-web issue ganglia#49 where host parameter is ignored by n…
eee56db 
…agios/check_metric.php
@vvuksan
Copy link
Member

vvuksan commented Mar 6, 2012

Embarrasing.

vvuksan added a commit that referenced this issue Mar 6, 2012
@vvuksan
Merge pull request #50 from scottbessler/master
703046f 
fixes issue #49
@rferrerasm
Copy link

Shouldn't this be applied to the other scripts?

jbuchbinder added a commit to jbuchbinder/ganglia-web that referenced this issue May 3, 2012
@jbuchbinder
full fix for issue ganglia#49 in other scripts
214cd78
vvuksan added a commit that referenced this issue May 9, 2012
@vvuksan
Merge pull request #84 from jbuchbinder/master
8672387 
Fix the rest of issue #49 in the other nagios scripts.
@vvuksan vvuksan closed this as completed May 9, 2012
jiongle1 pushed a commit to scantist-ossops-m2/ganglia-web that referenced this issue Apr 5, 2024
@vvuksan
Merge pull request ganglia#49 from pcpiela/master
82263a1 
Metric graphs are generated on demand
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@vvuksan @scottbessler @rferrerasm