-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New class CommandLineArgs to handle command line arguments #27
Conversation
CommandLineArgs parses the input that was passed in as a parameter to the java agent on the command line. These parameters are then used to configure Ganglia. Any missing parameter is given the value of null so that parameters defined in the XML can override them.
Fix regression introduced by 78fb5c7
Did you get the email from travis-ci.org advising that the build fails? https://travis-ci.org/ganglia/jmxetric/builds/26816663 It looks like some problem getting junit in the classpath when running the test cases. |
I didnt get any email but I noticed that the build failed. I will look
|
What I read online was to include the junit jar in a |
CommandLineArgs parses the input that was passed in as a parameter to the java agent on the command line. These parameters are then used to configure Ganglia. Any missing parameter is given the value of null so that parameters defined in the XML can override them.
…mmandlineargs Conflicts: src/main/java/info/ganglia/jmxetric/XMLConfigurationService.java
Great - thanks for resolving that. I completely avoid keeping any other binary JAR in any of my repositories. This is important for packaging: systems like Debian expect the tar.gz file (from the Github "releases" page) to be completely clean, with no binary artifacts inside. |
New class CommandLineArgs to handle command line arguments
CommandLineArgs parses the input that was passed in as a parameter
to the java agent on the command line. These parameters are then used to
configure Ganglia. Any missing parameter is given the value of null so
that parameters defined in the XML can override them.