Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New class CommandLineArgs to handle command line arguments #27

Merged
merged 7 commits into from
Jun 6, 2014
Merged

New class CommandLineArgs to handle command line arguments #27

merged 7 commits into from
Jun 6, 2014

Conversation

ngzhian
Copy link
Contributor

@ngzhian ngzhian commented Jun 5, 2014

CommandLineArgs parses the input that was passed in as a parameter
to the java agent on the command line. These parameters are then used to
configure Ganglia. Any missing parameter is given the value of null so
that parameters defined in the XML can override them.

ngzhian and others added 3 commits June 5, 2014 10:15
CommandLineArgs parses the input that was passed in as a parameter
to the java agent on the command line. These parameters are then used to
configure Ganglia. Any missing parameter is given the value of null so
that parameters defined in the XML can override them.
@dpocock
Copy link
Member

dpocock commented Jun 5, 2014

Did you get the email from travis-ci.org advising that the build fails?

https://travis-ci.org/ganglia/jmxetric/builds/26816663

It looks like some problem getting junit in the classpath when running the test cases.

@ngzhian
Copy link
Contributor Author

ngzhian commented Jun 6, 2014

I didnt get any email but I noticed that the build failed. I will look
around for a solution, do you know how I can solve this?
On 6 Jun, 2014 4:14 am, "Daniel Pocock" notifications@github.com wrote:

Did you get the email from travis-ci.org advising that the build fails?

https://travis-ci.org/ganglia/jmxetric/builds/26816663

It looks like some problem getting junit in the classpath when running the
test cases.


Reply to this email directly or view it on GitHub
#27 (comment).

@ngzhian
Copy link
Contributor Author

ngzhian commented Jun 6, 2014

What I read online was to include the junit jar in a lib folder and travis-ci will be able to find the jar on the classpath, but I don't think thats the right way, hm.
UPDATE Okay silly me, all the while it was in the wrong directory, so the tests worked on eclipse, but not when maven runs them. It's been fixed and Travis CI is green now!

CommandLineArgs parses the input that was passed in as a parameter
to the java agent on the command line. These parameters are then used to
configure Ganglia. Any missing parameter is given the value of null so
that parameters defined in the XML can override them.
…mmandlineargs

Conflicts:
	src/main/java/info/ganglia/jmxetric/XMLConfigurationService.java
@dpocock
Copy link
Member

dpocock commented Jun 6, 2014

Great - thanks for resolving that.

I completely avoid keeping any other binary JAR in any of my repositories. This is important for packaging: systems like Debian expect the tar.gz file (from the Github "releases" page) to be completely clean, with no binary artifacts inside.

dpocock added a commit that referenced this pull request Jun 6, 2014
New class CommandLineArgs to handle command line arguments
@dpocock dpocock merged commit 1e83ed1 into ganglia:master Jun 6, 2014
@ngzhian ngzhian deleted the commandlineargs branch June 6, 2014 06:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants