-
Notifications
You must be signed in to change notification settings - Fork 787
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Swipe between slides not work correctly when autoplay is enabled #298
Comments
I got the same problem and I was writing the same issue. Thank you for posting! |
here is solution for stop timer function onPanStart (e) {
if (running) { onTransitionEnd(); }
+ if (autoplay && animating) { stopAutoplayTimer(); }
panStart = true;
if (carousel) {
caf(rafIndex);
rafIndex = 0;
}
... and for start timer function onPanEnd (e) {
...
if (swipeAngle) { moveDirectionExpected = '?'; } // reset
+ if (autoplay && !animating) { setAutoplayTimer(); }
} please, implement this fix to next release |
This is how i fixed it:
Hope it helps!! |
@martin-badin So you want the interval for autoplay start right after the touch end? |
Yes, I want but this bug should be fixed in the package. |
Added in this commit. |
Thanks |
Hi @ganlanyuan thank you for fixing this, but how can i download this edited package? |
@Jack89ita This change is not published yet, so you won't be able to download via npm. |
@Jack89ita |
@TitanFighter Thank you! |
The bug is still showing when autoplayHoverPause is set as true |
@martin-badin The bug is still here version config When I drag and hold with mouse on slide item and get out of slider with cursor, animation resume (animation should not resume when drag is hold) |
Issue description: Hello, when I use autoplay and dragging function simultaneously the interval for autoplay isn't reset when a user swipe between slides. See example. Please, reset the interval when a user swipe between slides.
Demo link/slider setting: http://jsfiddle.net/p5wdjLn2/12/
Browser name && version: Chrome 69.0.3497.100
OS name && version: macOS Mojave 10.14
The text was updated successfully, but these errors were encountered: