0.5.0 tumbleweed build failure

[jubalh]

I get the following build failure for finalcut on openSUSE Tumbleweed:

[   61s] libtool: compile:  g++ -DHAVE_CONFIG_H -I. -I.. -Iinclude -Wall -Werror -DCOMPILE_FINAL_CUT -O2 -Wall -D_FORTIFY_SOURCE=2 -fstack-protector-strong -f
unwind-tables -fasynchronous-unwind-tables -fstack-clash-protection -Werror=return-type -g -Wall -Wextra -Wpedantic -O2 -Wall -D_FORTIFY_SOURCE=2 -fstack-prot
ector-strong -funwind-tables -fasynchronous-unwind-tables -fstack-clash-protection -Werror=return-type -g -c fwidgetcolors.cpp  -fPIC -DPIC -o .libs/fwidgetco
lors.o
[   61s] In file included from /usr/include/string.h:494,
[   61s]                  from /usr/include/c++/9/cstring:42,
[   61s]                  from foptimove.cpp:23:
[   61s] In function 'char* strncpy(char*, const char*, size_t)',
[   61s]     inlined from 'void finalcut::FOptiMove::rightMove(char*, int&, int, int)' at foptimove.cpp:819:18,
[   61s]     inlined from 'int finalcut::FOptiMove::horizontalMove(char*, int, int)' at foptimove.cpp:804:15,
[   61s]     inlined from 'int finalcut::FOptiMove::relativeMove(char*, int, int, int, int)' at foptimove.cpp:687:28:
[   61s] /usr/include/bits/string_fortified.h:106:34: error: 'char* __builtin_strncpy(char*, const char*, long unsigned int)' specified bound 512 equals destination size [-Werror=stringop-truncation]
[   61s]   106 |   return __builtin___strncpy_chk (__dest, __src, __len, __bos (__dest));
[   61s]       |          ~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
[   61s] /bin/sh ../libtool  --tag=CXX   --mode=compile g++ -DHAVE_CONFIG_H -I. -I..  -Iinclude -Wall -Werror -DCOMPILE_FINAL_CUT -O2 -Wall -D_FORTIFY_SOURCE=2 -fstack-protector-strong -funwind-tables -fasynchronous-unwind-tables -fstack-clash-protection -Werror=return-type -g -Wall -Wextra -Wpedantic  -O2 -Wall -D_FORTIFY_SOURCE=2 -fstack-protector-strong -funwind-tables -fasynchronous-unwind-tables -fstack-clash-protection -Werror=return-type -g -c -o fwidget.lo fwidget.cpp
[   61s] In function 'char* strncpy(char*, const char*, size_t)',
[   61s]     inlined from 'bool finalcut::FOptiMove::isMethod0Faster(int&, int, int)' at foptimove.cpp:941:18,
[   61s]     inlined from 'char* finalcut::FOptiMove::moveCursor(int, int, int, int)' at foptimove.cpp:524:23:
[   61s] /usr/include/bits/string_fortified.h:106:34: error: 'char* __builtin_strncpy(char*, const char*, long unsigned int)' specified bound 512 equals destination size [-Werror=stringop-truncation]
[   61s]   106 |   return __builtin___strncpy_chk (__dest, __src, __len, __bos (__dest));
[   61s]       |          ~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
[   61s] cc1plus: all warnings being treated as errors

I assume some library/compiler/toolchain was updated on oS TW.

[gansm]

Thanks for your feedback. Since release 0.5.0, many things have changed. This compilation error has been fixed upstream since December 2018. I have uploaded this version to the openSUSE Build Service.

http://download.opensuse.org/repositories/home:/gansm/openSUSE_Tumbleweed/

[jubalh]

That's quite strange.
Because https://build.opensuse.org/package/show/home:gansm/libfinal mentions libfinal 0.5.1.
But https://github.com/gansm/finalcut/releases only lists 0.5.0.

Can you tag here and upload to GitHub too? Then I'll be able to upload that newest version to official openSUSE repos.

Alternatively you could maybe mention which commits I need to put in a patch for 0.5.0 to work again.

Thanks!

[gansm]

The openSUSE version is an unofficial release, which I created yesterday from commit 635d7c6. This was the last commit before I switched the codebase to C++11. I also manually updated the version to 0.5.1. Therefore, I cannot tag this commit, because this version does not exist on GitHub. I'm currently working on the 0.6.0 release, which now supports full-width CJK characters.

[jubalh]

Well it's not an official release if it doesn't exist upstream :-)
Other distributions also won't be able to package it.

If I understood you right, then you can just:

git checkout https://github.com/gansm/finalcut/commit/635d7c691e8ef4692f2bc14c7124dcff6a21ae58
git tag 0.5.1
git push --tags

To have GitHub recognize it. Maybe you can even select a commit instead of a tag in the 'create release' page.
Otherwise I'll just take the commits until 635d7c6 and create a patch with them.

Thanks for your time.

[gansm]

I have created the branch "interim-release" and released version 0.5.1 there.

https://github.com/gansm/finalcut/releases/tag/0.5.1

[jubalh]

Perfect, thank you!

[jubalh]

Thanks for making devel:libraries:c_c++/finalcut build again!