Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support emoji shortcodes #568

Merged
merged 1 commit into from
Nov 26, 2022
Merged

Conversation

kofuk
Copy link
Contributor

@kofuk kofuk commented Nov 13, 2022

Hi,

Thank you for developing very useful browser extension.

I tried adding support for :emoji_name: style emoji shortcodes.
For example, :thinking: renders 🤔 emoji.

I'll be glad if you like this feature.

@ganta ganta added this to the v2.0.0 milestone Nov 13, 2022
@ganta
Copy link
Owner

ganta commented Nov 13, 2022

@kofuk Thank you for your contribution.

I am currently working on a significant redesign for Version 2. #403
In addition, I am doing partial merges, so that pull requests for changes are not huge.

Sorry, you contributed code that is in migration.
Therefore, even if I merge this Pull Request, I will not be able to release it immediately.
I am also considering implementing with Lexical so that the code may change significantly.

I hope you will understand this.

@kofuk
Copy link
Contributor Author

kofuk commented Nov 13, 2022

Thank you for quick response.

Should I maintain this patch? or open another PR for version 2 in the future?

@ganta
Copy link
Owner

ganta commented Nov 14, 2022

@kofuk Sorry, I missed the inclusion of code for v1 in your Pull Request.

As I mentioned above, the v2 release is still not in sight.
Therefore, I would prefer to merge the code for v1 so that it can be released sooner and be more helpful to users.

Can you please remove the changes for v2 from this pull request?
The part using rehype is the implementation for v2.

@ganta ganta removed this from the v2.0.0 milestone Nov 14, 2022
@ganta ganta added the enhancement New feature or request label Nov 14, 2022
@kofuk
Copy link
Contributor Author

kofuk commented Nov 15, 2022

Removed changes for v2.

If the changes is ok, I'll squash these commits into one commit.

@kofuk
Copy link
Contributor Author

kofuk commented Nov 22, 2022

How about these changes?

@ganta
Copy link
Owner

ganta commented Nov 22, 2022

@kofuk I don't have enough time, sorry. Please be patient

@ganta
Copy link
Owner

ganta commented Nov 25, 2022

@kofuk Sorry to keep you waiting.

Looks good!
Please rebase your branch onto main branch and squash commits.

@kofuk
Copy link
Contributor Author

kofuk commented Nov 26, 2022

Thank you for reviewing.

Rebased and squashed these commits.

Copy link
Owner

@ganta ganta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kofuk Thank you.

I will work on the release.
Please wait until the Chrome Web Store approves the release.

@ganta ganta merged commit 3b63681 into ganta:main Nov 26, 2022
@kofuk
Copy link
Contributor Author

kofuk commented Nov 26, 2022

Thank you!

@kofuk kofuk deleted the support-emoji-shortcodes branch November 26, 2022 08:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants