-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support emoji shortcodes #568
Conversation
5db4891
to
584f6f8
Compare
@kofuk Thank you for your contribution. I am currently working on a significant redesign for Version 2. #403 Sorry, you contributed code that is in migration. I hope you will understand this. |
Thank you for quick response. Should I maintain this patch? or open another PR for version 2 in the future? |
@kofuk Sorry, I missed the inclusion of code for v1 in your Pull Request. As I mentioned above, the v2 release is still not in sight. Can you please remove the changes for v2 from this pull request? |
Removed changes for v2. If the changes is ok, I'll squash these commits into one commit. |
How about these changes? |
@kofuk I don't have enough time, sorry. Please be patient |
@kofuk Sorry to keep you waiting. Looks good! |
fcdc6da
to
d07b5bd
Compare
d07b5bd
to
6fc0ac0
Compare
Thank you for reviewing. Rebased and squashed these commits. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kofuk Thank you.
I will work on the release.
Please wait until the Chrome Web Store approves the release.
Thank you! |
Hi,
Thank you for developing very useful browser extension.
I tried adding support for
:emoji_name:
style emoji shortcodes.For example,
:thinking:
renders 🤔 emoji.I'll be glad if you like this feature.