feat: Applied a monospaced font to a code block #80
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
korosuke613
changed the title
|
CI通るように修正します |
korosuke613
force-pushed
the
enable-monospaced-font
branch
from
a0c5720
to
b8b187f
Compare
korosuke613
force-pushed
the
enable-monospaced-font
branch
from
b8b187f
to
9c051b8
Compare
ganta
requested changes
Jul 8, 2020
There was a problem hiding this comment.
@korosuke613
呼び出される頻度から、コンストラクタで構築したほうがパフォーマンス的にもよいかと思います。
変数名の指摘だけしましたので、ご確認ください〜。
| "Menlo", | ||
| "monospace", | ||
| ]; | ||
| private monospaceFontFamilies: string; |
There was a problem hiding this comment.
[MUST]
この変数名だと配列が入っているように見えてしまうので、monospaceFontFamiliesStringにしましょうか
There was a problem hiding this comment.
korosuke613
force-pushed
the
enable-monospaced-font
branch
from
9c051b8
to
9a53f73
Compare
Co-authored-by: Hideki Igarashi <hideki.develop@gmail.com>
korosuke613
force-pushed
the
enable-monospaced-font
branch
from
9a53f73
to
76c4e2d
Compare
ganta
approved these changes
Jul 9, 2020
There was a problem hiding this comment.
@korosuke613
Thank you for your contribution!
リリースは #83 とまとめてやろうと思います
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #81