New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
incus-0.3: Build failure openfga/go-sdk/oauth2/clientcredentials/clientcredentials.go: expects import "golang.org/x/oauth2" #34
Comments
Just a few notes for troubleshooting:
So it makes sense that the error is triggered when only considering the facts stated above. But why is it not triggered when building via |
this is a bug in the openfga repo, and should be filed & fixed there. They copied in code from the golang.org oauth2 package, but didn't modify the canonical import directive. It's not triggered in the Makefile because the dependencies aren't vendored in the repo, but only in the release. So the go tooling is pulling in the golang.org package because that's what the openfga package tells it to do. Confirm this by looking at incus's go.mod file which doesn't mention the openfga org. |
unfortunately, even after PR is accepted and fix is released, incus needs to update the openfga dependency and make a new release. |
OpenFGA promised a release today to fix this. So this may resolve in a day or two. |
https://github.com/openfga/go-sdk/releases/tag/v0.3.1 OpenFGA fixed release, Incus maintainers will include in tomorrow's 0.4.0 release. |
Unfortunately we can't as we support building on the latest two Go versions and OpenFGA 0.3.x only builds on 1.21 (not sure if an actual requirement of just an artifact of their go.mod). |
for completeness, OpenFGA released a version for go 1.20 to resolve this. |
Wow, thanks a lot for stepping in. I really thought there is something wrong on my side otherwise I would have reported that sooner. I'll therefore try my luck again once incus-0.4 is released. |
my pleasure, thanks for packaging Incus & LXD! |
0.4 is out, well, tag and tarballs are, still working on the announcement :) |
Great, thanks everyone. |
Great to hear! Also just a quick reminder to send us a PR for |
When trying to build
incus-0.3
from the release archive via RPM spec file theincusd
binary build will fail with:The error doesn't happen when building the project via
Makefile
.The text was updated successfully, but these errors were encountered: