Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

404 page title in English #1001

Closed
marktaylor46 opened this issue Nov 12, 2015 · 4 comments
Closed

404 page title in English #1001

marktaylor46 opened this issue Nov 12, 2015 · 4 comments
Assignees
Milestone

Comments

@marktaylor46
Copy link

The browser title for the 404 error page always seems to be in English.

I did a search on this in Gantry 5 and it appears that are a lot of places where this literal "Page not found" is hardcoded in english (presumably one of these ends up in the browser title) - see screenshot.
2015-11-12_10-26-48

I have a member who's site is correctly set up in Spanish language yet the browser page title shows english on the 404 page when the main message in the body of the page is correctly in Spanish.

2015-11-12_10-27-17

Link to forum topic:http://www.rockettheme.com/forum/joomla-template-ambrosia/250491-changing-404-page-not-found?start=0#1249956

.

@marktaylor46
Copy link
Author

Also body text specifically line 34 of /components/com_gantry5/gantry5.php line 34 is hardcoded in english language.

@marktaylor46
Copy link
Author

@mahagr
Copy link
Member

mahagr commented Mar 24, 2016

Yeah, the error is hard coded into English as it comes from an exception. Generally I do not want to translate our error messages, but I think this one might be exception as its not really an internal error where we want to be able to understand the error message.

@mahagr mahagr added the bug label Mar 24, 2016
@mahagr mahagr added this to the 5.3.0 milestone Mar 24, 2016
@marktaylor46
Copy link
Author

Also the hardcoded reference that needs to be changed is /components/com_gantry5/router.php 'Page not found' line 24 :

@mahagr mahagr self-assigned this Apr 11, 2016
@mahagr mahagr added the joomla label Jun 13, 2016
@mahagr mahagr closed this as completed Jun 13, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants