Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incompatible units in scss calculations #2903

Closed
JoomFX opened this issue Oct 14, 2021 · 12 comments · Fixed by #2904
Closed

Incompatible units in scss calculations #2903

JoomFX opened this issue Oct 14, 2021 · 12 comments · Fixed by #2904
Milestone

Comments

@JoomFX
Copy link
Contributor

JoomFX commented Oct 14, 2021

Hey guys,

The new SCSS compiler seems to be activated by default in Gantry 5.5 for all themes, not only for the themes that require it.

Anyway, if the user uses a value in any unit different than rem in the Breakpoints section, they will get an error.
This screenshot shows the issue in a clean Helium RocketLauncher installation.

This will need to be fixed in some of the templates that have such calculations. Here's another issue for example.
We also have few templates that need to be fixed 😃

Anyway, I will open a new PR that fixes the issue in Gantry (and Helium).

@jpolecheck
Copy link

I'm using the Notio template from RocketTheme with rem as the Breakpoints data, but am still getting the CSS issue. Is there another area I need to update?

2021-10-18 10_44_44-ATV MN - Administration

@mahagr
Copy link
Member

mahagr commented Oct 19, 2021

Try first to install the CI build from https://gantry.org/downloads

If that doesn't work, the theme may have overrides for breakpoints. @hexplor is working on updating themes, so he may know if there's more to it.

@jpolecheck
Copy link

jpolecheck commented Oct 19, 2021 via email

@mahagr
Copy link
Member

mahagr commented Oct 19, 2021

Yes.

@jpolecheck
Copy link

jpolecheck commented Oct 19, 2021 via email

@mahagr
Copy link
Member

mahagr commented Oct 19, 2021

That one you need to fix manually if you want to get the site up ASAP.

Just edit templates/rt_notio/scss/notio/sections/_sidebar.scss line 50 and change it a bit. Here's example on what kind of changes you should make:

b16d10e (<- click)

Just add the calc(#{ and } just like in the example above.

CC @hexplor If you were not aware of the issue.

@mahagr
Copy link
Member

mahagr commented Oct 19, 2021

I reopen the issue so it's easier for others to find.

@mahagr mahagr reopened this Oct 19, 2021
@jpolecheck
Copy link

jpolecheck commented Oct 19, 2021 via email

@mahagr
Copy link
Member

mahagr commented Oct 19, 2021

You can always take a backup from that file. It should be really simple change, just make the browser to do the calculation instead of SCSS (which doesn't really support mixing units).

@jpolecheck
Copy link

Tried a couple things, couldn't get it to work. Can I Venmo someone on your crew to take a crack at it? :)

@mahagr mahagr closed this as completed Oct 20, 2021
@mahagr mahagr added this to the 5.5.1 milestone Oct 20, 2021
@mahagr
Copy link
Member

mahagr commented Oct 22, 2021

@jpolecheck RT team is trying to get new versions of the themes out starting from next week.

@Avgrafica
Copy link

Avgrafica commented Dec 28, 2021

Same issue with Hydrogen 5.5.7
I tried to modify the _flex.scss file by forcing the calc (# but it didn't work

Edit
Ok, also modified file _breakpoints.scss, now work. Hope to not must do this modification at every update

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants