Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Particle Joomla article - Joomla 5 - Error on previous/next button #3218

Open
tramber91 opened this issue Dec 21, 2023 · 16 comments
Open

Particle Joomla article - Joomla 5 - Error on previous/next button #3218

tramber91 opened this issue Dec 21, 2023 · 16 comments

Comments

@tramber91
Copy link

tramber91 commented Dec 21, 2023

Hi

I test Gantry 5 (5.5.17), template Hydrogen in Joomla 5.01 (php 81) and I have this error in core particle Joomla article when i want to go to a next or a previous article (Click on the button).

Joomla\CMS\Event\Module\RenderModuleEvent::onSetSubject(): Argument #1 ($value) must be of type object, null given, called in /home/etlbertrand/biomecanique.en-toutes-lettres.fr/libraries/src/Event/AbstractEvent.php on line 225

Few topic on the web with same message
github.com/joomla/joomla-cms/issues/42339

No issue If on article, i click on previous/next button.

Any idea.

thanks

Bertrand

@tramber91
Copy link
Author

tramber91 commented Dec 22, 2023

As Example, I test this morning in a new simple Gantry 5 test site
https://www.hydrogen.en-toutes-lettres.fr/index.php/test
Particle "Joomla article" was OK in Joomla 4.4.1 (link to Blog category)
I update to 5.0.1 and as you can see the error when you click on "Next" but the website not crash.

So I have 3 different test website with same issue in Joomla 5.

Maybe the famous TODO i already seen at the bottom of the twig particle file (script).

$.ajax({ type : 'GET', data : request, indexValue : id + '-particle', success: function (response) { if(response.data){ $('#' + this.indexValue).html(response.data[0].html); } else { // TODO: Improve error handling -- instead of replacing particle content, display flash message or something... $('#' + this.indexValue).html(response.message); } }, error: function(response) { // TODO: Improve error handling -- instead of replacing particle content, display flash message or something... $('#' + this.indexValue).html('AJAX FAILED ON ERROR'); } }); return false;

@tramber91
Copy link
Author

@hexplor
Copy link
Collaborator

hexplor commented Mar 20, 2024

I appreciate your patience with this. Looking into this.

@hexplor
Copy link
Collaborator

hexplor commented Mar 20, 2024

Hello,
I just tested that on both PHP 8.1 and 8.2 and also on both Hydrogen and Helium and cannot reproduce, :( This must be some configuration-specific problem. Did you install any 3rd part extensions? On the ticket, you mentioned there's hint that it might be EasySocial related..

hexplor added a commit that referenced this issue Mar 29, 2024
…cle Joomla article - Joomla 5 - Error on previous/next button #3218
@hexplor
Copy link
Collaborator

hexplor commented Mar 29, 2024

@tramber91 i fixed that in Gantry CI builds, should be available in few minutes for download at: https://gantry.org/downloads. Can you test if it's fixed?

@hexplor
Copy link
Collaborator

hexplor commented Apr 2, 2024

Hey @tramber91 can you confirm if it's fixed with CI build so we can proceed? https://gantry.org/downloads

@tramber91
Copy link
Author

tramber91 commented Apr 3, 2024

Hi @hexplor
as I said in RT Forum
https://rockettheme.com/forum/free-particles/290557-particle-joomla-article-ok-for-joomla-5?start=30#1457572

I have Recheck in hydrogen test website the Last build (Gantry 5.5.18-dev-b9d76f303 and Hydrogen v5.5.18-dev-b9d76f303)
www.hydrogen.en-toutes-lettres.fr

menu link test
Not good - Fatal Error
If particle joomla article is added directly in base outline - I have always an error.
To see the file with error I put "No" to Compile Twig parameter.
www.hydrogen.en-toutes-lettres.fr/index.php/test

menu link test module
GOOD
I use not same outline as previous link
particle joomla article added as module - GOOD, i can see the particle and play with previous and next button
was not possible before, thanks
www.hydrogen.en-toutes-lettres.fr/index.php/test-module

take care

@hexplor
Copy link
Collaborator

hexplor commented Apr 22, 2024

Hey @tramber91 can you please send me login & pass to your test website at karol[at]rockettheme.com. I'm unable to recreate your issue and I need to make sure it's solved. Thanks!

@tramber91
Copy link
Author

@hexplor Done

@hexplor
Copy link
Collaborator

hexplor commented Apr 29, 2024

Hey @tramber91
Thank you so much for this. It took me some time, but finally, thanks to your install, I was able to reproduce that issue on my local machine. New build is coming, please download it (should be available in the couple of minutes) and let me know if it's fixed for you. CI Builds link: https://gantry.org/downloads#ci-builds

@tramber91
Copy link
Author

Hi @hexplor :=) Perfecto, no more error after install
last thing you can have a look on labels display in particle (joomla 5 color issue)
g5_particle_label_J5

@hexplor
Copy link
Collaborator

hexplor commented Apr 30, 2024

Hi @hexplor :=) Perfecto, no more error after install last thing you can have a look on labels display in particle (joomla 5 color issue) g5_particle_label_J5

I'm not experiencing that at all, even on your installation. Where do you see that?

@tramber91
Copy link
Author

Hi @hexplor , in each particle of the test website. you have login then you can check. Try to create a new module / particle.

@hexplor
Copy link
Collaborator

hexplor commented Apr 30, 2024

Not seeing anything odd @tramber91. Your test site below:
image
What browser and OS are you using and which versions? Did that happen before?

@tramber91
Copy link
Author

@hexplor Just check admin template config
I'm in Dark mode - Follow OS settings
Never change this config

I change it to : Use Dark color scheme
You can check on your side, logically should be similar than me.

Dark mode can be nice be better to disabled it in Gantry website !

@tramber91
Copy link
Author

So you can close the topic and made the new version Gantry, compatible joomla 5, available, thanks again

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants