WordPress menu system enhancements

[newkind]

This was postponed to be added after release, but I cannot find ticket for that so I'm going to make a list of items that Gantry 5 WP menus still needs to get done.

• Ability to use Widgets in menu
• Synchronize particle menu items with WP core menu
• When renaming menu item title, that item get reordered to be the last one

[mahagr]

Needed by the next theme.

[marktaylor46]

Another RT member with the same issue here http://www.rockettheme.com/forum/wordpress-theme-fluent/274903-menu-issue

We really need to get this resolved IMHO

[blizam]

I'm sure it's related. When I try and create multi-columns or generally change the order of things nothing saves. I'll save my changes in the Menu Editor, browse away (to the Outlines tab or something) and when I come back everything, or 90% of my changes at least, have reverted. I'm sure I'll eventually get there by writing the menu.yaml file myself but I wanted to make sure this behavior was included in the fix. I did have child items that I made parents which may be part of my issues, as described by others here.

[blizam]

For what it's worth I notice pretty strange behavior in how things are saved in the [menu-name].yaml file:

--sometimes items don't save an Object ID, but they still seem to work... the Object ID seems important to me though, no?
--If you have 2 menu items with the same name saving becomes erradict; the items get mixed up
--ampersands (and presumably other special characters) in the Menu Display Name 'cause erradict behavior... sometimes it saves ok, othertimes not... I've run into instances where clicking the settings icon on an item returns a popup message of "404 not found - Oops, Menu item not found."
--I don't understand the Object_IDs at all really... probably some WP thing I just don't understand... but the Object IDs I see get saved on the items: list in the yaml file are not always the Object ID of the WP Menu Manager... sometimes they are... sometimes they're within a number or 2 and somehow still seem to work... other times I've had the number be the exact Object ID as I see in the WP Menu Manager and I still get the 404 not found - Oops, Menu item not found when trying to change a menu item's settings

[mkdev-de]

3 years later: Any idea if that gets fixed?

[Tekspec]

We have a large development in progress which requires use of this menu system, should we assume this bug cannot be fixed?

[mahagr]

I took yet another deep look into this issue and I have found a fix for the issue. It will take some time to get it fully fixed and tested, but I'm hopeful that it will finally be fixed to the next version (5.4.26) which should be out within 2 months.

You can see the progress in https://github.com/gantry/gantry5/tree/feature/wp_menu branch.

Right now the branch has the logic to save all our extra data into the menu items, but only menu item specific data is loaded from the database. This means that ordering, columns and particles are not yet loaded from the new DB storage.

[mahagr]

UPDATE: Make that Gantry 5.4.27 as there was a regression bug in 5.4.25 which needed a quick patch.

[blizam]

Will the new DB storage for the Menu address this issue?

#1194

[Safeworld4women]

Re @blizam comment - Likewise - would be good to know if #1194 will be fixed in update.

[mahagr]

Regarding to WPML menu issue, I don't think that synching menu particles to the database fixes the issue, but I have not tested it yet.

As an update, I've made great progress on fully utilizing WP menu items in the database inside Gantry menu and its manager. There are still some minor issues that I need to fix as well as a decent amount of testing needed, but the implementation looks to be working great in most parts.

[careercoder]

I highly recommend doing the following...

Whenever a person is modifying the menu - create a temporary menu with what is being created.

Erase the core menu - and replace with the new menu once saved.

The only way I resolved this was by erasing the YAML file.

[mahagr]

Closing in favour of #2473

[LMKWeb]

I was having the same issue reported with menu items in a Joomla site - were the improvements made just to the WP branch? Should I open a new issue for Joomla?

[mahagr]

I'm going to look into Joomla and Grav next.