Enable notes on blacklists and increase text limits #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
XDcedar
reviewed
Jun 22, 2023
| let noteNode = document.createElement("div"); | ||
| noteNode.id = "biliscope-profile-note" | ||
| noteNode.className = "section user-info" | ||
| noteNode.innerHTML = ` | ||
| <p class="user-info-title"><span class="info-title">备注</span></div> | ||
| <div class="be-textarea be-input--append"> | ||
| <textarea rows="3" type="textarea" maxlength="150" class="be-textarea_inner" id="biliscope-note-textarea">${noteData[userId] || ""}</textarea> | ||
| <textarea | ||
| rows="${Math.max(3, (noteData[userId] || "").split("\n").length)}" |
There was a problem hiding this comment.
这里的 rows 是不会考虑折行的，这个是 intended 的么？
另外，我觉得还需要设置一个上界，不然换行太多导致太长了也不好。Math.min(20, Math.max(3, (noteData[userId] || "").split("\n").length))，希望不会显得太累赘
There was a problem hiding this comment.
肯定不考虑折行，因为browser的设置或者一些其它的插件包括未来B站的变化都可能改变折行位置。所以是明确的\n才变。
显示多少是用户决定的，用户自己要把card填满是用户自由。这里给出的提示是很明确的，不做额外的限制了。
| <div class="idc-meta" style="${noteData && noteData[data["mid"]] ? "": "display: none"}"> | ||
| <span class="idc-meta-item">${noteData ? noteData[data["mid"]]: ""}</span> | ||
| <div class="idc-meta" style="${noteDataToDisplay(noteData, data["mid"]) ? "": "display: none"}"> | ||
| <span class="idc-meta-item">${noteDataToDisplay(noteData, data["mid"])}</span> |
There was a problem hiding this comment.
天哥我还是建议加一个 text-overflow: ellipsis; 再限制一下长度，一行内容也可能很长的
There was a problem hiding this comment.
参考上面的回复，这是用户可控的内容，不需要做额外处理。
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.